Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stacktrace.clj] Allow condensed stack trace format #386

Open
sirmspencer opened this issue Jan 28, 2020 · 2 comments
Open

[stacktrace.clj] Allow condensed stack trace format #386

sirmspencer opened this issue Jan 28, 2020 · 2 comments

Comments

@sirmspencer
Copy link
Contributor

sirmspencer commented Jan 28, 2020

https://clojure.atlassian.net/browse/CLJ-2463

The linked patch to clojure condenses the stack trace to the important line(s). It would be great to see something similar for ring.

Important lines would be the cause and the lines for files in the current app (handler.clj:116 my-app.handler/a-function)

To me this is the most important for the sterr logging. When the error is displayed in the browser, it seems fine to show the whole trace. In the browser it looks like there is some attempt to style less important line with a lighter font. This could be a little easier to read if the same important line(s) were highlighted.

@sirmspencer sirmspencer changed the title [stacktrace.clj] Allow condensed stack trace format to match clojure 1.10.1 update [stacktrace.clj] Allow condensed stack trace format Jan 28, 2020
@sirmspencer sirmspencer reopened this Jan 28, 2020
@sirmspencer
Copy link
Contributor Author

I see that errors are also returned with a :trimmed-elems that is the shorter trace. This is a good key to use instead of trying to filter elems based on file or something else.

@sirmspencer
Copy link
Contributor Author

I have a solution working on my local project, Ill create a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant