Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement driver.Pinger interface for druid_api_sql_driver #6901

Open
1 task
k-anshul opened this issue Mar 17, 2025 · 2 comments
Open
1 task

Implement driver.Pinger interface for druid_api_sql_driver #6901

k-anshul opened this issue Mar 17, 2025 · 2 comments
Assignees

Comments

@k-anshul
Copy link
Member

The druid SQL driver(runtime/drivers/druid/druidsqldriver/druid_api_sql_driver.go) does not implement driver.Pinger interface.
This means the conn.Ping method does not make any API calls.
We use Ping method in our runtime health_checks. Without properly implemented Ping methods these checks can miss issues with OLAP connectivity.

@pjain1
Copy link
Member

pjain1 commented Mar 17, 2025

what about metrics view check here. They should run irrespective of Ping and return health check error?

@k-anshul
Copy link
Member Author

The metrics_view check only report the number of metrics_view in error state and adds a separate log explaining the full error.
We can't fail health checks if metrics view are in error state since there can be multiple reasons for metrics view to be in error state and not just OLAP connectivity error.
To explicitly rely on OLAP connectivities we have explicit Pings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants