Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible-lint #283

Closed
psztoch opened this issue Sep 27, 2023 · 7 comments · May be fixed by #312
Closed

ansible-lint #283

psztoch opened this issue Sep 27, 2023 · 7 comments · May be fixed by #312
Labels

Comments

@psztoch
Copy link

psztoch commented Sep 27, 2023

Please, update syntax to be compatible with ansible-lint.

Use of ansible-lint --write will be huge and fast step. :-)
I assume that, as the author, you will quickly check whether anything has been broken by the machine.

@riemers
Copy link
Owner

riemers commented Sep 28, 2023

I do use ansible lint but have not used it in this project. Just running --fix might change more then needed. But if you feel up to it you could also just run it, make a PR see if the changes are solid.. unless @guenhter has some time?

@guenhter
Copy link
Collaborator

When we run this and make everything linted, do you think it would be worth add this to the CI pipeline so that future PR's always fail in case they are not linted?

@riemers
Copy link
Owner

riemers commented Sep 28, 2023

That would make sense yes.. a PR could have a check for that.

@psztoch
Copy link
Author

psztoch commented Sep 29, 2023

Once you achieve no errors, it is worth adding it to CI.

@abielan
Copy link

abielan commented Nov 9, 2023

@guenhter Thx for some progress.
Girls from Warsaw are waiting for part two.

@guenhter
Copy link
Collaborator

guenhter commented Nov 9, 2023

@abielan At the moment, I'm very busy and don't have much time for this. But feel free to tackle a few of the linter issues and submit it as PR. I'm happy to review and merge that then in a timely manner.

@github-actions github-actions bot added the Stale label Jan 24, 2024
Repository owner deleted a comment from github-actions bot Jan 24, 2024
@github-actions github-actions bot removed the Stale label Jan 25, 2024
Copy link

Seems this message did not get a lot of love. This does not mean it was not seen but time wise might not have made it to proper attention. This is just the clean up action ;)

@github-actions github-actions bot added the Stale label Feb 25, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants