Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service_test.clj sometimes fails on travis #894

Open
mcorbin opened this issue Dec 20, 2017 · 0 comments
Open

service_test.clj sometimes fails on travis #894

mcorbin opened this issue Dec 20, 2017 · 0 comments

Comments

@mcorbin
Copy link
Contributor

mcorbin commented Dec 20, 2017

The error was:

FAIL in (threadpool-service-test) (service_test.clj:155)
stats

expected: (= (instrumentation/events s)
             [{:service "riemann executor cat accepted rate", :metric 3/5, :tags ["riemann"], :state "ok", :time 5}
              {:service "riemann executor cat completed rate", :metric 3/5, :tags ["riemann"], :state "ok", :time 5}
              {:service "riemann executor cat rejected rate", :metric 0, :tags ["riemann"], :state "ok", :time 5}
              {:service "riemann executor cat queue capacity", :metric 2, :tags ["riemann"], :state "ok", :time 5}
              {:service "riemann executor cat queue size", :metric 0, :tags ["riemann"], :state "ok", :time 5}
              {:service "riemann executor cat queue used", :metric 0, :tags ["riemann"], :state "ok", :time 5}
              {:service "riemann executor cat threads active", :metric 0, :tags ["riemann"], :state "ok", :time 5}
              {:service "riemann executor cat threads alive", :metric 1, :tags ["riemann"], :state "ok", :time 5}])

actual: (not (= [{:service "riemann executor cat accepted rate", :metric 3/5, :tags ["riemann"], :state "ok", :time 5}
                 {:service "riemann executor cat completed rate", :metric 2/5, :tags ["riemann"], :state "ok", :time 5}
                 {:service "riemann executor cat rejected rate", :metric 0, :tags ["riemann"], :state "ok", :time 5}
                 {:service "riemann executor cat queue capacity", :metric 2, :tags ["riemann"], :state "ok", :time 5}
                 {:service "riemann executor cat queue size", :metric 0, :tags ["riemann"], :state "ok", :time 5}
                 {:service "riemann executor cat queue used", :metric 0, :tags ["riemann"], :state "ok", :time 5}
                 {:service "riemann executor cat threads active", :metric 1, :tags ["riemann"], :state "ok", :time 5}
                 {:service "riemann executor cat threads alive", :metric 1, :tags ["riemann"], :state "ok", :time 5}]

                [{:service "riemann executor cat accepted rate", :metric 3/5, :tags ["riemann"], :state "ok", :time 5}
                 {:service "riemann executor cat completed rate", :metric 3/5, :tags ["riemann"], :state "ok", :time 5}
                 {:service "riemann executor cat rejected rate", :metric 0, :tags ["riemann"], :state "ok", :time 5}
                 {:service "riemann executor cat queue capacity", :metric 2, :tags ["riemann"], :state "ok", :time 5}
                 {:service "riemann executor cat queue size", :metric 0, :tags ["riemann"], :state "ok", :time 5}
                 {:service "riemann executor cat queue used", :metric 0, :tags ["riemann"], :state "ok", :time 5}
                 {:service "riemann executor cat threads active", :metric 0, :tags ["riemann"], :state "ok", :time 5}
                 {:service "riemann executor cat threads alive", :metric 1, :tags ["riemann"], :state "ok", :time 5}]))

As you can see, the thread was still active and the test hasn't been fully processed (the test launched (dotimes [i 3] (run)) but stopped at 2.

I haven't be able to reproduce the bug locally yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant