Refactor AdapterCounter #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhpvorderman
force-pushed
the
refactoradaptercounter
branch
from
65af499 to
1927740
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Pull request details were added to CHANGELOG.rst
Documentation was updated (if needed)
Simplify data structures to allow for easier vectorization.
Utilize dynamic dispatch to write a single AVX2 algorithm, which can handle cases of 2,3 or 4 matchers with equal efficiency.
No more reliance on
#ifdef __SSE2__throughout the code.Fixes #211
Fixes #171 . The autovectorization is simply is not productive enough. A hand-written avx2 implementation is much faster than whaver auto-vectorization can produce. I tested this using GCC14. As such it is better to write a separate ARM-based implementation when the need arises.