New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hard coded default wi-fi interface #176
Comments
First off, thanks for raising this! 🤔 Ooh, configuration. We've not needed any thus far, so this is an interesting proposal. Normally I'd be reluctant to add a config file for one setting, but I agree the other options are a little... lame. The other option is a runtime flag '-i interface', ala If you want to put a RFC/PR for a config proposal, it'd be good to see what that'd look like before we completely commit to it. |
Here's a vote for a command-line based parser thing like the first option. It's what I used in a previous PR (#135) and if it helps, this might be a little less ugly: system_profiler SPNetworkDataType | grep -A1 AirPort | grep -o en. |
Right now, the default wifi interface is en0, however, it's not actually en0 on all devices, so commands like 'm wifi ls' simply returns the message "en0 is not a Wi-Fi interface."
As it sits, there's a few options:
networksetup -listallhardwareports | awk -F': ' '/Hardware Port: Wi-Fi/ { getline; print $2}'
every single time. Ouch._W_DEVICE
appropriately in their shell config. Meh.networksetup
command and then create a configuration script file inINSTALL_DIR/etc/m.conf
(or somewhere better). So after installation that file would contain contain_W_DEVICE=en1
(or whatever networksetup actually found). Then have m source that config file at runtime.I'd be happy to submit a PR based on consensus of what would be the preferred method. Thoughts?
Thanks!
The text was updated successfully, but these errors were encountered: