Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Clickable and Input Component #857

Open
ericluap opened this issue May 24, 2020 · 0 comments
Open

Improve Clickable and Input Component #857

ericluap opened this issue May 24, 2020 · 0 comments
Labels
A-components Area: Consumer-exposed components providing some convenience over the primitives enhancement New feature or request

Comments

@ericluap
Copy link
Contributor

ericluap commented May 24, 2020

Some ideas for improving the functionality of the Clickable and Input component:

  • Clicking inside of an input should change the cursor position on mouse down, not mouse up.

  • The cursor should still be captured by the input when it leaves the input so that highlighting text can work well.

For Clickable (possibly unnecessary):

  • Clickable should use Hooks.mouseCapture instead of its own mouse capture system

  • Mouse down on a clickable, leaving the clickable, re-entering the clickable, and then mouse up back on the clickable should still count as a click.
    In other words, if the mouse down and mouse up occur on the clickable, it should not matter if the cursor left.

@glennsl glennsl added A-components Area: Consumer-exposed components providing some convenience over the primitives enhancement New feature or request labels May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-components Area: Consumer-exposed components providing some convenience over the primitives enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants