Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging prevents the Revery_Lwt eventLoop from working #791

Open
lessp opened this issue Mar 6, 2020 · 3 comments
Open

Logging prevents the Revery_Lwt eventLoop from working #791

lessp opened this issue Mar 6, 2020 · 3 comments
Labels
A-rendering Area: Rendering artifacts, features etc. bug Something isn't working

Comments

@lessp
Copy link
Member

lessp commented Mar 6, 2020

  • Operating System:
    macOS
  • Revery Version:
    0.30.0
  • OCaml version:
    ~4.8
  • Native, Bytecode, or JS build:
    Native

Revery_Lwt.startEventLoop() does not work when logging is enabled. Removing:

Timber.App.enable();
Timber.App.setLevel(Timber.Level.perf);

Fixes the issue.

@lessp lessp added bug Something isn't working A-rendering Area: Rendering artifacts, features etc. labels Mar 6, 2020
@glennsl
Copy link
Member

glennsl commented Mar 7, 2020

Curious. Does all three lines really need to be removed? Or would removing any of these solve it?

@lessp
Copy link
Member Author

lessp commented Mar 7, 2020

Curious. Does all three lines really need to be removed? Or would removing any of these solve it?

Yes, I'm curious as well!

This was late last night, so I might update the issue with further findings today.

@lessp
Copy link
Member Author

lessp commented Mar 24, 2020

I went back and checked and it seems as though the issue only arises when enabling Timber. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rendering Area: Rendering artifacts, features etc. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants