New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When restoring, cannot rewrite files that are readonly #4757
Labels
Comments
MichaelEischer
added
type: feature enhancement
improving existing features
category: restore
labels
Apr 10, 2024
Fixing this restore issue is planned for restic 0.17.0 as part of properly handling in-place restores, see also #4575 . There are a few more corner cases to handle here, the go mod cache is especially hard to handle correctly (the directories are also recursively marked as read-only). |
This has already been fixed by #4611. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Output of
restic version
What backend/service did you use to store the repository?
Local
Problem description / Steps to reproduce
NOTE: the following script should be copy+pasted into bash! (zsh didn't work for me)
Expected behavior
Actual behavior
For (3), here's the output displayed in the terminal, for the final "restore" command, i.e.
DEBUG_LOG=logfile.txt restic restore latest --target $DIR1
I've also attached the debug logs
Do you have any idea what may have caused this?
I'm not certain.
Maybe we should be hitting this codepath, but it's not for some reason?
restic/internal/restorer/fileswriter.go
Lines 56 to 64 in 6091029
Also - is this related to this previous issue re: readonly directories? (The current issue is about readonly files)
Did restic help you today? Did it make you happy in any way?
It's a cool tool! 😄
I'm not sure if the maintainers have time to look at this - if not, I am willing to contribute some code to help fix this.
However, I will definitely need some help/guidance. In particular:
cmd/restic/cmd_restore.go
Restorer
- seems like this also does some kind of traversal through the file directory tree?filesWriter
cmd/restic/cmd_restore_integration_test.go
? Or, write more of a "unit-level" test?The text was updated successfully, but these errors were encountered: