Throwable PHP7

[lon9man]

Expected Behavior

PHP7 needs to catch Throwable instead Exception

Current Behavior

try-catch don't catch Throwable instead Exception

Possible Solution

refactor all try-catch

My Environment

• PHP-Resque version: latest
• PHP version: 7.1
• Operating System and version: Ubuntu 18.10

[BenoitDD-URIOS]

No need to refactor all try/catch.
PHP Resque Exceptions just have to implement Throwable interface.

[lon9man]

@Benoit-amo
not sure that understood.
for example:

php-resque/lib/Resque/Worker.php

Line 257 in fdca42b

catch(Exception $e) {

how this example can be refactored in other way than replacing Exception to Throwable?

[BenoitDD-URIOS]

Ok, I missed that.
How many catch like this ?

[lon9man]

@Benoit-amo
with concrete "catch(Exception $e)" it seems only 1 occurence.

but exist some child-exceptions which has extended from Exception
OR
type-hinted parameters in methods:

php-resque/lib/Resque/Failure.php

Line 25 in fdca42b

public static function create($payload, Exception $exception, Resque_Worker $worker, $queue)

i am not sure which one should be updated to Throwable and which one not.

[danhunsaker]

There are a lot of PHP 7 updates that haven't been done yet. This one is relatively minor, as \Exception extends \Throwable anyway, so only \Errors will be uncaught, which is consistent with PHP 5 behavior. (AIUI, it's illegal to extend or even implement the \Throwable interface directly anyway, so only type hints should be updated even when we version bump to add this change.)

In other words, this will be a BC break, and will need several other PHP 7 changes in place before it makes any sense to do. So this will be an item on the PHP 7 checklist.