Broken with Feign 12.5+

[nilo85]

Resilience4j version: 1.7.x (cant run java17) (but very likely same issue in latest as same builder pattern is applied)

Java version: java11

Thanks for raising a Resilience4j issue.

I opened up this issue with Feign today:
OpenFeign/feign#2341

They have in Feign 12.5 onwards made the builder return a new builder at some point and the Resilience4jFeign.Builder is effectively not used when hitting build..

To workaround in my project I have injected the following class in your package:

package io.github.resilience4j.feign;

import feign.Feign;

public final class PatchedResilience4jFeign {

  public static Feign.Builder setInvocationHandler(Feign.Builder builder, FeignDecorator invocationDecorator) {
    return builder.invocationHandlerFactory(
        (target, dispatch) -> new DecoratorInvocationHandler(target, dispatch,
            invocationDecorator));
  }

}

Where I call PatchedResilience4jFeign.setInvocationHandler() just before I build the builder =)

Cant be done from my packages as DecoratorInvocationHandler is not public

[nilo85]

I see someone suggested this in one of the comments of another issue with same cause:
OpenFeign/feign#2163 (comment)

However, important it gets back ported to 17.x as we are a few who are stuck in older java versions =/

[nilo85]

I guess another option could be to extend internalBuild() instead of build() (as they made build final)
https://github.com/OpenFeign/feign/blob/master/core/src/main/java/feign/BaseBuilder.java#L302

[nilo85]

I made a pull request addressing the issue here #2127

[RobWin]

Unfortunately it's difficult for me to still support 1.7.x:
A lot of changed in the deployment and release pipeline between 1.7 and 2.0, because JFrog shut down JCenter/Bintray

I'm so busy at work at the moment, that it's difficult for me to find time to merge the changes from 2.x back to 1.7.x. :(
Not sure if someone could support here?

[nilo85]

I understand =) Not sure I can be of much aid there, I have created 3 PRs, one for each branch but was very long time ago I tried to get something published in a public repo.

Well in the meantime maybe you can merge the change based on the master branch PR and get the fix for all current version users of resilience4j to get it to work. Its quite nasty as it does not produce any errors or warnings or anything as of now, it just dont work, so if you dont have good tests verifying the fallbacks etc, you wouldn't notice.

Regarding 1.7.x in my personal case, we have a central middleware library that controls it all and I could live with a custom hack there.