Skip to content

Expose more re_renderer symbols and allow shader reload for shaders outside of the regular shader directory #10081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 26, 2025

Related

What

See title.
The shader reload changes feel a little bit dubious to me, needs more testing in the future. But doesn't break existing debug-only shader reloading in the viewer (tested that) so I think this is fine.

@Wumpf Wumpf added 🔺 re_renderer rendering, graphics, GPU exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 26, 2025
@Wumpf Wumpf mentioned this pull request May 26, 2025
Copy link

github-actions bot commented May 26, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
af3d5a2 https://rerun.io/viewer/pr/10081 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf changed the title Expose more re_renderer symbols and allow shader reload for shaders outside of the regular shader directory Expose more re_renderer symbols and allow shader reload for shaders outside of the regular shader directory May 26, 2025
@emilk emilk self-requested a review May 27, 2025 07:07
@Wumpf Wumpf merged commit 1d0625f into main May 27, 2025
45 checks passed
@Wumpf Wumpf deleted the andreas/split-out-re_renderer-changes branch May 27, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🔺 re_renderer rendering, graphics, GPU
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants