-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HostHeaderSSLAdapter with a Host header that includes port #288
Comments
(that fixes the issue locally for me) |
ok, ok, I guess I should just send a PR. How's that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello! Love your library!
I recently tried to use HostHeaderSSLAdapter with a connection not on port 443, so the Host header includes the port, and I was surprised to see the exception include the port:
...and lo, HostHeaderSSLAdapter drops the host header it finds straight in to connection_pool_kwargs["assert_hostname"]. How about making that
?
The text was updated successfully, but these errors were encountered: