Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor version lists #207

Open
2 tasks
AMDmi3 opened this issue Feb 2, 2023 · 0 comments
Open
2 tasks

Refactor version lists #207

AMDmi3 opened this issue Feb 2, 2023 · 0 comments

Comments

@AMDmi3
Copy link
Member

AMDmi3 commented Feb 2, 2023

There are version lists on projects, versions_compact and information pages, and these need to be fixed.

  • First of all, there should be a single piece code which creates these lists. For now, there are three pieces of code which do the same thing in slighly different ways:
    • packageset_aggregate_by_version
    • iter_aggregate_versions
    • packages_to_summary_items
  • It should handle some cases better, for instance recalled and vulnerable status. E.g. if an input list contains 1.2.3, 1.2.3 with recalled flag and 1.2.3 with vulnerable flag, it should merge these into a single 1.2.3 entry with both recalled (Improve recalled status handling #205) and vulnerable flags. Likewise, all places should handle sorting wrt. sink flag and *_is_patch flags equally, and calculate spread correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant