Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: use own certificate and/or disable ssl #227

Open
cfrepak opened this issue Jul 18, 2023 · 4 comments
Open

[Feature Request]: use own certificate and/or disable ssl #227

cfrepak opened this issue Jul 18, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request in-progress This ticket is currently being worked on
Milestone

Comments

@cfrepak
Copy link

cfrepak commented Jul 18, 2023

Binner version

2.6.0

Operating System

Debian 12

Describe the bug and the steps to reproduce it

I am having problems installing Binner on our network because of the built-in self-signed certificate. It is not possible to allow trusted access through the browser this way. A network wide installation of the certificate is impossible for obvious reasons. In addition, the self-signed certificate prevents the use of a reverse proxy, which is the preferred method for neglecting the port at the end of the URL, as well as leaving the general configuration of the web host to a web server.

I would like to be able to either include my own (CA signed) certificates, or even better disable SSL altogether.

Would you like to attach your appsetings.json configuration?

No response

Screenshots or Videos (Optional, but they help!)

No response

Are you able to contribute a PR? (No is ok!)

None

@cfrepak cfrepak added the bug Something isn't working label Jul 18, 2023
@replaysMike
Copy link
Owner

I'll take a look at this and see if I can come up with a solution. Self-signed certs are the norm for this kind of thing, but I agree if you want to integrate it into a corporate network for multiple users it would be nice to allow setting of an alternate SSL certificate as well as the option to disable.

I'll look at this for v2.6.4 next week.

@replaysMike replaysMike added this to the v2.6.4 milestone Apr 23, 2024
@replaysMike replaysMike self-assigned this Apr 23, 2024
@replaysMike replaysMike added enhancement New feature or request and removed bug Something isn't working labels Apr 23, 2024
@joeyhagedorn
Copy link

Thanks for looking into this! I also would love to specify a custom SSL certificate. I use Let’s Encrypt to get valid SSL certificates for other services I run, which is increasingly commonplace. It’s pretty easy to setup a script that uses the ACME protocol to renew certs automatically.

@replaysMike
Copy link
Owner

Agreed, this was on the backburner since certificates weren't working on unix environments. Certificates are always a pain on windows, I'll try to schedule this shortly.

@replaysMike replaysMike added the in-progress This ticket is currently being worked on label Aug 14, 2024
@Neustradamus
Copy link

Yes it is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in-progress This ticket is currently being worked on
Projects
None yet
Development

No branches or pull requests

4 participants