-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emp rollback rolls back scaling #1108
Comments
I think the confusion here comes from the fact that scaling is the only change that can ever mutate a release. So if you scale up, it mutates the current release, instead of creating a new release. However, rollbacks literally just take an old release, and copies it as the new release. I agree, the behavior here is a little strange, but it's the intended (originally designed) behavior, so I'm gonna change the tag on this from bug to enhancement. A better behavior would probably be to remove the mutability of scaling, and make scaling events create a new release, so it's easier to tell what you're rolling back to, and easier to see a history of scaling (and why with the |
Saw this earlier today in staging/prod. Something recently has caused empire to reset scale for an app when rolling back, which I'm pretty sure isn't the behavior we want. This happened at first with a 0.11 emp client, so I upgraded and saw the same behavior with 0.13.
The text was updated successfully, but these errors were encountered: