Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonoff-SC missing friendly name on Information page #2

Open
mike2nl opened this issue Aug 1, 2018 · 2 comments
Open

Sonoff-SC missing friendly name on Information page #2

mike2nl opened this issue Aug 1, 2018 · 2 comments

Comments

@mike2nl
Copy link

mike2nl commented Aug 1, 2018

Used tools:

  • Notepad++ v7.5.7

Used Hardware:

  • SONOFF-SC

Have you look for this feature in other issues and in the wiki?
-> Yes.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
-> When you have the SOnOff-SV in use, a envoirement sensor, you will miss
the friendly name on the information web page which can be a little
irritating because when you have set the hostname different you miss it.

Describe the solution you'd like
A clear and concise description of what you want to happen.
-> I have changed a very little part in the xdrv_02_webserver.ino file
to add this information and it works perfect.

Original Code:
if (SONOFF_IFAN02 == Settings.module) { maxfn = 1; }

Changed Code:
if ((SONOFF_IFAN02 == Settings.module) || (SONOFF_SC == Settings.module)) { maxfn = 1; }

Additional context
Add any other context or screenshots about the feature request here.
... i'm willing to help with much more ...

@reloxx13
Copy link
Owner

this is also wanted, cuz the friendyname is ONLY for alexa devices.

if their is no relais to switch, their will be no friendlyname to setup.

and in the line before the maxfn is defined by teh count of devices/relaises.
in you change you overwrite and hardcoded the maxfriendlyname to 1, which means you will never be able to set more friendlynames if you (dont forget other users) add another relais to the modul.

@mike2nl
Copy link
Author

mike2nl commented Aug 16, 2018

I see but that is the original tasmota code not mine!
I have added that here only: || (SONOFF_SC == Settings.module))

Because the original code: if (SONOFF_IFAN02 == Settings.module) { maxfn = 1; }
It is a max of one. So where is the issues here? Possible it's to early today to see the issue.

And possible you can help me out to understand what you mean.

So in my eyes i see no issues with that because that changing
does no harm. I have now 223 sonoff devices and i see no issues at all

reloxx13 pushed a commit that referenced this issue Sep 3, 2018
reloxx13 pushed a commit that referenced this issue Sep 28, 2018
update fork from arendst/tasmota
reloxx13 pushed a commit that referenced this issue Mar 18, 2019
Final fixes, cleanup, and optimizations
reloxx13 pushed a commit that referenced this issue Apr 5, 2019
reloxx13 pushed a commit that referenced this issue Jun 20, 2019
reloxx13 pushed a commit that referenced this issue Oct 10, 2019
reloxx13 pushed a commit that referenced this issue Mar 1, 2020
github-actions bot pushed a commit that referenced this issue Sep 23, 2020
Pull request to catch up to arendst/Tasmota development branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants