Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folders shared with same name display path in VFS admin menu #660

Open
jbrown123 opened this issue Jun 30, 2024 · 3 comments
Open

Folders shared with same name display path in VFS admin menu #660

jbrown123 opened this issue Jun 30, 2024 · 3 comments

Comments

@jbrown123
Copy link

jbrown123 commented Jun 30, 2024

BEFORE

  • Are you using a reverse-proxy, like nginx?

Not using nginx or any proxy, also not applicable to the issue

To Reproduce

Add a real disk folder and leave the name the same as the terminal folder name (windows).
The VFS display in the admin panel shows the path rather than the name

Describe the bug

Note the "c:\" on the front of the name in the VFS list.

A picture is worth a thousand words ...
image

Expected behavior

I expected the name to be displayed without the path (c:\) in front of it.

Changing the name, including just changing the case of one letter, causes it to "do the right thing" and just display the name without the path.

image

The name should ALWAYS just be the name, no matter what. The path should NEVER be added automatically. Sure, if you want to copy the path to the name FIELD when a new item is added, fine (although I think that's a horrible default). But whatever is in the name field should be the unadulterated name in the list.

Screenshots

Inline above

Environment (please complete the following information):

  • OS: Win 10
  • HFS Version 0.52.9 (latest stable)
  • Browser chrome (N/A)

Additional context

None

@jbrown123 jbrown123 added the bug Something isn't working label Jun 30, 2024
@jbrown123 jbrown123 changed the title Folders shared from root with same name display path in VFS admin menu Folders shared with same name display path in VFS admin menu Jun 30, 2024
@rejetto
Copy link
Owner

rejetto commented Jul 1, 2024

this is just a misunderstanding.
As you say, you want the name to not include C:\ but in your screenshot that's exactly how it is in the NAME field.
You didn't experience a problem when browsing the files, you just expected to have a problem, right?
The VFS on the left is not strictly the name field. Look again, and see the name is displayed in normal color, while the C:\ is grayed out. The gray part is trying to be more informative on the configuration of the entry, so that in a small space i'm telling you both the name and the path.
Maybe using a smaller font for the gray part could be help telling there's a difference between the 2 parts?
like this
image

@rejetto rejetto removed the bug Something isn't working label Jul 1, 2024
@jbrown123
Copy link
Author

It's confusing because it displays the path sometimes but not others.
I'd say be consistent. Either always have the path or never put it there.

@rejetto
Copy link
Owner

rejetto commented Jul 2, 2024

i see your point, and you may be right, but i'm not sure.
i'd like to get the opinion of more people on it, as i like it as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants