Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable codegen + caching the generated code. #638

Open
yujin-wu opened this issue Jan 24, 2022 · 1 comment
Open

Stable codegen + caching the generated code. #638

yujin-wu opened this issue Jan 24, 2022 · 1 comment

Comments

@yujin-wu
Copy link

Issue

While working on CSP compliance for plotly, we had the challenge of avoiding codegen in regl. We found that some changes in Regl were necessary to make this possible, in particular making generated code stable.

The changes we needed are in #637 and I believe they are beneficial to regl:

  1. Make generated code for the same shader identical
  • across runs in any app and construction order
  • across all devices
  1. Cache for the generated code, which is practical now that a lot of generated code will be identical.
    The PR text has more details.

PR

#637

@yujin-wu
Copy link
Author

yujin-wu commented Jan 24, 2022

@rreusser (+@alexcjohnson)

Hey Ricky, would you be able to have a look please? 🙂

@yujin-wu yujin-wu changed the title Stable codegen + cache generated code. Stable codegen + caching the generated code. Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant