Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitelisting for certain websites to skip PocketUniverse #1

Open
jqphu opened this issue Jul 26, 2022 · 1 comment
Open

Add whitelisting for certain websites to skip PocketUniverse #1

jqphu opened this issue Jul 26, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jqphu
Copy link
Collaborator

jqphu commented Jul 26, 2022

Waiting for PocketUniverse on sites that they trust is a little cumbersome. Examples of these websites include OpenSea, LooksRare, nftnerds.ai, etc.

It would be great to have a whitelist so PocketUniverse can get out of the way immediately.

However, the solution must address the following scenarios.

  1. The website itself gets hacked (e.g. premint). We likely want to check the smart contract we're interacting with. If it's not known we probably still want to run the simulation.

  2. The extension didn't work vs it skipped the simulation. We don't want scenarios where the extension crashes to be mistaken for a whitelist.

We should consider having this as an advanced feature for our power users.

@jqphu jqphu added the enhancement New feature or request label Jul 26, 2022
@jqphu
Copy link
Collaborator Author

jqphu commented Jul 28, 2022

Discussed in discord.

Likely need both whitelisting contract option and a temporary on-off button that's easy to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant