🦋 Changeset detected

Latest commit: 09f8f2d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 09f8f2d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

Sent with 💌 from NxCloud.

Some problems occurred because my fork was not completely synced. Resolved it now.

@BatuhanW Added tests and some changes. I'd appreciate it if you could take a look when you have a moment. I plan to update the documentation later since there might be more changes before merging. Additionally, it seems we're lacking functionality where the user can call useForm with different action based on the call. This would enable users to extend the functionality and create new rows in the DataGrid, not just edit existing ones. Same goes for delete. I will look into it more when I catch time.

@BatuhanW Added tests and some changes. I'd appreciate it if you could take a look when you have a moment. I plan to update the documentation later since there might be more changes before merging. Additionally, it seems we're lacking functionality where the user can call useForm with different action based on the call. This would enable users to extend the functionality and create new rows in the DataGrid, not just edit existing ones. Same goes for delete. I will look into it more when I catch time.

@beg1c appreciate the effort! Looks good initially, I'll review more in detail later. Also cc @aliemir @alicanerdurmaz

@BatuhanW @alicanerdurmaz updated docs. Do you think we should accept boolean editable as prop to useDataGrid or is this PR over?

For further usage I don't think we need that prop, but we could break older versions if we don't accept it. If some users have their own implementation of editable datagrid, and they didn't declare processRowUpdate on <DataGrid /> component, <DataGrid /> processRowUpdate will trigger our useForm onFinish every time column is commited.

So for example if someone defined their data grid as:

<DataGrid
    {...dataGridProps}
    columns={columns}
    onRowEditStart={ownSetIdFunction}
    onRowEditCommit={ownMutateFunction}
/>

which is wrong as processRowUpdate should be used for migrations from DataGrid version 6, our processRowUpdate from ...dataGridProps spread could break that functionality.

I don't know, what do you think?

@BatuhanW @alicanerdurmaz updated docs. Do you think we should accept boolean editable as prop to useDataGrid or is this PR over?

For further usage I don't think we need that prop, but we could break older versions if we don't accept it. If some users have their own implementation of editable datagrid, and they didn't declare processRowUpdate on <DataGrid /> component, <DataGrid /> processRowUpdate will trigger our useForm onFinish every time column is commited.

So for example if someone defined their data grid as:

<DataGrid
    {...dataGridProps}
    columns={columns}
    onRowEditStart={ownSetIdFunction}
    onRowEditCommit={ownMutateFunction}
/>

which is wrong as processRowUpdate should be used for migrations from DataGrid version 6, our processRowUpdate from ...dataGridProps spread could break that functionality.

I don't know, what do you think?

I believe you are right. We should accept editable prop.

something like this:

useForm({
  queryOptions: {
    enabled: editable,
  },
});

processRowUpdate: async (newRow, oldRow) => {
   if(!editable) return
   /* .... */
}
  

Hey @beg1c we've merged releases/april branch, could you re-open your PR?