Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Update @ant-design/charts package to v2 for examples #5474

Closed
BatuhanW opened this issue Jan 4, 2024 · 6 comments
Closed

[FEAT] Update @ant-design/charts package to v2 for examples #5474

BatuhanW opened this issue Jan 4, 2024 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed wontfix This will not be worked on

Comments

@BatuhanW
Copy link
Member

BatuhanW commented Jan 4, 2024

Is your feature request related to a problem? Please describe.

Due to dependency issues with @ant-design/charts@1, we are having installation issues. We have .npmrc file to workaround this issue, but it's not ideal.

Describe alternatives you've considered

No response

Additional context

No response

Describe the thing to improve

  1. Update @ant-design/charts package to v2 in the following examples and remove .npmrc:
  1. Test these applications by running locally and make sure they work as expected.

  2. Check if their blog posts needs to be updated:

https://github.com/refinedev/refine/blob/master/documentation/blog/2021-11-12-issue-tracker-refine.md

https://github.com/refinedev/refine/blob/master/documentation/blog/2023-04-06-finefood-admin-dashboard.md

@BatuhanW BatuhanW added the enhancement New feature or request label Jan 4, 2024
@devhik0
Copy link

devhik0 commented Jan 9, 2024

Hello, if i am allowed to take this task, i would like to assign it to myself to do it. Thanks for your understanding

@BatuhanW
Copy link
Member Author

Hello @devhik0 assigned this issue to you. Looking forward to your PR!

@devhik0
Copy link

devhik0 commented Jan 10, 2024

Here is PR to check its details. #5523

@devhik0

This comment was marked as off-topic.

@BatuhanW

This comment was marked as off-topic.

Copy link

stale bot commented May 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 5, 2024
@stale stale bot closed this as completed May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants