Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linkify-code doesn't linkify inline links like https://x.com #7995

Closed
1 task done
BlazeFTL opened this issue Nov 2, 2024 · 2 comments · Fixed by #8151
Closed
1 task done

linkify-code doesn't linkify inline links like https://x.com #7995

BlazeFTL opened this issue Nov 2, 2024 · 2 comments · Fixed by #8151
Labels
enhancement help wanted small Issues that new contributors can pick up

Comments

@BlazeFTL
Copy link

BlazeFTL commented Nov 2, 2024 •
edited
Loading

Description

Is is possible to make theose links Clickable?

Screenshot_2024-11-02-12-44-10-538_org mozilla fenix

Extension version

24.10.28

Browser(s) used

Firefox Nightly Android

Token ⚠️

  • I set a token in the options page. I understand that some features require a token to work.
@BlazeFTL BlazeFTL added the bug label Nov 2, 2024
@fregante fregante changed the title Links Are Not Clickable In Issues linkify-code doesn't linkify inline links like https://x.com Nov 2, 2024
@fregante
Copy link
Member

fregante commented Nov 2, 2024 •
edited
Loading

Yes we never supported inline links. Live example:

  • https://example.com

But it works here (once we publish #7985)

https://example.com

@fregante fregante added help wanted small Issues that new contributors can pick up and removed under discussion labels Dec 9, 2024
@fregante
Copy link
Member

fregante commented Dec 9, 2024

It's a small change, PR welcome. The main difference is that the code should avoid already-linked elements, like <a><code></a>:

and <code><a></code>, as seen on https://github.com/refined-github/refined-github/commits/main/?after=62f91b26a6af3263a123c6c52266308af4e82328+34

@kovsu kovsu mentioned this issue Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted small Issues that new contributors can pick up
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

linkify-code - Support inline links forkandcook/refined-github
2 participants
@fregante @BlazeFTL