Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Semi-)Automatically read token from page after generation #7914

Open
fregante opened this issue Oct 15, 2024 · 2 comments
Open

(Semi-)Automatically read token from page after generation #7914

fregante opened this issue Oct 15, 2024 · 2 comments
Labels
enhancement meta Related to Refined GitHub itself under discussion

Comments

@fregante
Copy link
Member

Description

I'm afraid that accessing or acting on the token generation page might feel a bit creepy but I'm looking for ways to make the installation process as smooth as possible.

IMG_6052

So what if on this page we add a "Use for Refined GitHub" button? Ideally we only show this button after following our own link. Clicking it would automatically also close the welcome page and redirect you to the wiki as usual.

If we can safely detect tokens "created for Refined GitHub" we could alternatively read it immediately and make it clear that this is part of the process. This might actually be easier to implement and longer lasting (no UI no problem)

Example URLs

https://github.com/settings/tokens

@fregante

This comment was marked as resolved.

@fregante fregante added the meta Related to Refined GitHub itself label Oct 30, 2024
@fregante
Copy link
Member Author

fregante commented Nov 6, 2024

Maybe via sessionStorage since if I remember correctly it's per-tab. So:

  1. Open token-creation page with custom parameter
  2. Detect parameter and mark tab as "token for Refined GitHub"
  3. On the last page, detect and save token
  4. Clear sessionStorage
  5. Display notification and invite to open the wiki
  6. In the welcome page: Detect the new token and self-close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement meta Related to Refined GitHub itself under discussion
Development

No branches or pull requests

1 participant