⚠️ Features broken on new issues (beta)

[fregante]

Description

I'm sure every isConversationList feature is currently broken on that page.

How to replicate the issue + URL

Test URLs:

• Testing download-directory/download-directory.github.io#141
• https://github.com/eslint/eslint/issues
• https://github.com/tc39/proposal-await.ops/issues

The beta is enabled by organization. These three have it. You can spam issues on https://github.com/download-directory/download-directory.github.io/issues if necessary, I'll delete them once we're done. Or leave comments in download-directory/download-directory.github.io#141, better.

[fregante]

By the way, finally we have an autocomplete!

[fregante]

More features are broken, like the label alignment

[fregante]

Bye quick-comment-hiding

[fregante]

These are features running on isIssueList and isSingleIssue

I'll check these off after verifying them, or with 👋 if they're no longer needed

Important features

• clean-conversation-sidebar broken in new issue view #8024
• status-subscription missing from new issue view #7968
• close-as-unplanned (see below)
• comments-time-machine-links
• conversation-activity-filter
• expand-all-hidden-comments
• hide-low-quality-comments

Rest

• comment-excess
• hide-navigation-hover-highlight
• keyboard-navigation
• linkify-user-edit-history-popup
• linkify-user-location
• preview-hidden-comments
• quick-mention
• selection-in-new-tab
• shorten-links
• toggle-everything-with-alt

Done

• jump-to-conversation-close-event
• show-names
• small-user-avatars
• sticky-sidebar
• table-input
• reactions-avatars
• scrollable-areas
• prevent-link-loss
• collapsible-content-button
• embed-gist-inline
• emphasize-draft-pr-label
• linkify-user-labels
• jump-to-conversation-close-event
• avoid-accidental-submissions 👋
• esc-to-cancel 👋
• clean-conversation-headers 👋
• prevent-comment-loss 👋
• quick-comment-hiding 👋
• bugs-tab
• ci-link
• clean-repo-tabs
• clean-rich-text-editor
• close-out-of-view-modals
• command-palette-navigation-shortcuts
• copy-on-y
• esc-to-deselect-line
• fit-textareas
• hide-diff-signs
• hide-user-forks
• improve-shortcut-help
• linkify-branch-references
• linkify-code
• linkify-line-numbers
• more-dropdown-links
• one-key-formatting
• parse-backticks
• profile-hotkey
• quick-comment-edit
• quick-new-issue
• releases-tab
• reload-failed-proxied-images
• repo-avatars
• repo-header-info
• repo-wide-file-finder
• show-whitespace
• sort-conversations-by-update-time
• tab-to-indent
• unfinished-comments
• user-local-time

[fregante]

The list above has already been verified. Unless you see that the feature is no longer needed, you can assume they're not working. That would save time from having to build that table

[kovsu]

Here has two avatar.

https://github.com/download-directory/download-directory.github.io/issues?q=is%3Apr

[fregante]

cc @ToBinio #7924

[ToBinio]

@fregante could it be that GitHub is rolling out that feature?
cause for is:pr it also renders images without refined Github

should I open a PR and just fix it for is:pr or do you think it will come for normal issues too and the feature should just be disabled for the new view

[fregante]

Uh, they did 😅

[fregante]

• preview-hidden-comments

We should hold off on implementing this one, their header layout is messy on mobile and I expect them to change it completely. Only fix it if it's a simple class change

[fregante]

For advanced features like close-as-unplanned, we have to use the UI on behalf of the user because we no longer have the good ol' form element 😒

For example in #7893 this meant opening the dropdown menu and simulating a click on the Edit item.

Here I'd expect the dropdown arrow to be hidden and a new custom button to be added. When the button is clicked, we show the arrow, open it, click "close as not planned", then click the new "close" button.

I wonder if it's just easier to do it via API and call triggerConversationUpdate (which is also likely broken on the new issue view), but I think that as long as every part here is selectable, it's actually not too difficult:

refined-github/source/features/quick-comment-edit.tsx

Lines 25 to 33 in 60217e8

	async function editReactComment({delegateTarget: editButton}: DelegateEvent<MouseEvent, HTMLButtonElement>): Promise<void> {
	(editButton.nextElementSibling as HTMLButtonElement).click();
	await delay(1); // Allow the dropdown to open
	document
	.activeElement! // The focus is now on the first item in the dropdown
	.parentElement! // Select the list element
	.querySelector('[aria-keyshortcuts="e"]')! // Find the edit item
	.click();
	}