Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to distinguish review required statuses when I've already reviewed the PR. #7340

Closed
Swiddis opened this issue Apr 26, 2024 · 1 comment

Comments

@Swiddis
Copy link

Swiddis commented Apr 26, 2024

Description

When working on repositories that have a high PR throughput and require 2+ reviews per PR, it's hard to tell at a glance where my reviews are needed. Currently all PRs that need more reviews have a "Review required" label, regardless of if I've reviewed them or not.

Current view

I'd like to propose introducing another label along the lines of "Pending reviews", to distinguish cases where I've already reviewed a PR and we're waiting for someone else to review it. The new label would be applicable when I've reviewed a PR but it's still waiting for someone else to review it, and for PRs I've authored. The "Review required" label would be reserved for PRs I still need to review.

Proposed view

The information is already available when hovering over the PR, e.g. when I've approved a PR it says "You approved this pull request" at the bottom of the pop-up while when I haven't it says "You have a pending review request". This feature request is to have the information visible in the PR list directly.

grafik

Example URLs

https://github.com/opensearch-project/dashboards-observability/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc or any other repository that has a 2 person rule for PR reviews.

@fregante
Copy link
Member

The list is very crowded and very often we get requests to add more information to it. We can't.

You can already request the PRs that are awaiting review from you with GitHub's own filters

image

@fregante fregante closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants