Where is redux-saga definitions?

[OnkelTem]

I use WebStorm for development of create-react-app applications.
So I have all the regular things installed and redux-saga among them.

Currently the following sequence

import createSagaMiddleware from "redux-saga";
const sagaMiddleware = createSagaMiddleware();
sagaMiddleware.run(rootSaga);

leads to an IDE warning on sagaMiddleware.run line:

Unresolved function or method run()
Inspection info: Checks that called functions are valid. The validation works in JavaScript, html or jsp files.

So it seems that I don't have any proper type definitions installed.

I tried to search for them in the WebStorm types repository but found nothing.

I also searched for @types/redux-saga package on npmjs and found this one: https://www.npmjs.com/package/@types/redux-saga

As you can see it shows the deprecation message:

This is a stub types definition for redux-saga (https://github.com/redux-saga/redux-saga). redux-saga provides its own type definitions, so you don't need @types/redux-saga installed!

Yeah, cool. It means I should have it already, should I? Then where is it?

[stianjensen]

You're probably looking for the package https://www.npmjs.com/package/@redux-saga/types instead, published from the packages/types folder of this repository: https://github.com/redux-saga/redux-saga/tree/master/packages/types

[Andarist]

We publish TS types to npm and they are available from the IDE. Not sure why WebStorm doesn't pick them up but I'm afraid that you would have to research this on your own.

[tannaz97shr]

That's OK. It works without WebStorm recognizing the function.

[artyom-88]

Got the same problem with WebStorm

[orekav]

I am facing the same issue.
I went to:
Webstorm -> File -> Settings -> Languages & Frameworks -> JavaScript -> Libraries -> Downloads

But it doesn't show "redux-saga", it does show "redux-saga-routines" & "redux-saga-tester".
I also have set the node_modules folder from the project but still do not recognize it.

In Visual Studio Code works perfectly

[OnkelTem]

@orekav I don't have any redux or saga related libraries there.

But it works for me now, although my initialization is done in a *.ts file now, not sure if it matters or not.

[neurosnap]

Closing due to inactivity.

[tsopeh]

Sorry for reopening this issue but I've encountered a similar issue. I'm working on a mixed javascript/typescript project using WebStorm; when I import an effect in a js file, I'm not getting any completion or type hints.

import { race } from "redux-saga/effects";

But if I change the import path to:

import { race } from "@redux-saga/core/effects";

everything starts working as expected.

Is importing from @redux-saga/core/effects considered a bad practice?

[neurosnap]

So generally speaking, yes, it is not ideal to rely on internal packages because those paths are subject to change and we make no guarantees that they will exist.

If we follow the breadcrumbs for how redux-saga/effects package is structured:

• redux-saga/packages/redux-saga/package.json

  Line 16 in 9c59ac9

  "types": "./effects.d.ts",

• redux-saga/packages/redux-saga/effects.d.ts

  Line 1 in 9c59ac9

  export * from '@redux-saga/core/effects'

• redux-saga/packages/core/effects/effects.d.ts

  Line 1 in 9c59ac9

  export * from '../types/effects'

• redux-saga/packages/core/types/effects.d.ts

  Line 1 in 9c59ac9

  import { Action, AnyAction } from 'redux'

As you can see in the second bullet, that's how we are forwarding the types to the user through redux-saga/effects.

We have no plans on changing the internal structure of this project. I'm not entirely sure why your IDE is not picking up the types. I'm curious, if you reference redux-saga/effects inside your TS-enabled files, does tsc check the types properly?

[tsopeh]

Hi @neurosnap, thanks for answering 🚀

I can confirm that (locally in WebStorm) type inference works properly for redux-saga/effects, if I change the file extension from .js to .ts. Unfortunately this is not a viable solution for a large project that is mostly written in JS.

Locally, VS Code works fine, but I've created a minimal repro on StackBlitz (remote editor) that demonstrates my issue for both TS and JS files.

Unfortunately, this issue seems to be inconsistent between local and remote editors.