Skip to content

Commit 2c3b871

Browse files
committed
Make displayed Web errors more meaningful
1 parent e7dd6f1 commit 2c3b871

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

misc/dist/html/editor.html

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -701,9 +701,14 @@ <h2 id="welcome-modal-title" class="welcome-modal-title">Important - Please read
701701
editor = new Engine(editorConfig);
702702

703703
function displayFailureNotice(err) {
704-
const msg = err.message || err;
705-
console.error(msg);
706-
setStatusNotice(msg);
704+
console.error(err);
705+
if (err instanceof Error) {
706+
setStatusNotice(err.message);
707+
} else if (typeof err === 'string') {
708+
setStatusNotice(err);
709+
} else {
710+
setStatusNotice('An unknown error occured');
711+
}
707712
setStatusMode('notice');
708713
initializing = false;
709714
}

misc/dist/html/full-size.html

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,14 @@
134134
}
135135

136136
function displayFailureNotice(err) {
137-
const msg = err.message || err;
138-
console.error(msg);
139-
setStatusNotice(msg);
137+
console.error(err);
138+
if (err instanceof Error) {
139+
setStatusNotice(err.message);
140+
} else if (typeof err === 'string') {
141+
setStatusNotice(err);
142+
} else {
143+
setStatusNotice('An unknown error occured');
144+
}
140145
setStatusMode('notice');
141146
initializing = false;
142147
}

0 commit comments

Comments
 (0)