Skip to content
This repository has been archived by the owner on Feb 4, 2025. It is now read-only.

Async upload providers #465

Open
ginkoid opened this issue Aug 7, 2020 · 0 comments
Open

Async upload providers #465

ginkoid opened this issue Aug 7, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@ginkoid
Copy link
Member

ginkoid commented Aug 7, 2020

At the moment, all upload providers are loaded synchronously with require():

// FIXME: use async loading
// eslint-disable-next-line @typescript-eslint/no-var-requires
const ProviderClass = require(path.join('../providers', name)).default

We should use import() instead, such as in email providers:

const { default: Provider } = await import(path.join('../providers', emailConfig.provider.name)) as { default: ProviderConstructor }

@ginkoid ginkoid added the enhancement New feature or request label Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant