Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean dependencies #234

Open
moznuy opened this issue May 4, 2022 · 0 comments · May be fixed by #239
Open

Clean dependencies #234

moznuy opened this issue May 4, 2022 · 0 comments · May be fixed by #239

Comments

@moznuy
Copy link
Contributor

moznuy commented May 4, 2022

Public:

  • six: is used only in
    @classmethod
    def from_redis(cls, res: Any):
        # TODO: Parsing logic copied from redisearch-py. Evaluate.
    Is it needed for anything else, do we intend to support Python 2?
  • pptree: is it used? I see only adopted code from it:
    """
    This code adapted from the library "pptree," Copyright (c) 2017 Clément Michard
    and released under the MIT license: https://github.com/clemtoy/pptree
    """
  • types-redis, types-six: do they need to be public?
  • cleo: is it used?
  • hiredis: right now is mandatory in public deps. Could we make it optional and/or just encourage in docs? There was this: Failing to install. Cannot install hiredis #150

Dev:

  • ipdb: is it used? drags whole ipython
  • pylint: is it used?
  • is whole pytest-xdist really necessary? I don't see that tests are slow without it, is it for different purpose? P.S. In fact it's even slower for me with parallel test
  • email-validator: is it used? It used for pydantic.EmailStr. Maybe make it optional for public?
  • is tox used for anything right now? Is it for local dev? Makefile does not contain an entry for it.
  • on the account of poetry lock: I think it's more then slightly out of date
@moznuy moznuy linked a pull request May 6, 2022 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant