Fix recv() 120s Timeout on EAGAIN by Retrying Indefinitely #69
+160
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tezc
reviewed
Feb 27, 2025
tezc
reviewed
Feb 27, 2025
tezc
reviewed
Feb 27, 2025
tezc
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing with redis server may fail on configured 120-second timeout on recv()
in RESTORE MODE with a big key, say >4GB. It takes Redis server a long time to
process the RESTORE command before ACK. The solution is to modify the logic to
continuously retry without a timeout. An appropriate log message will be printed
every 10 seconds, such as: "No reply from Redis server for 10 seconds."
If requested, we can expose conifguration to fine tune timeout duration and retries.