Skip to content

[BUG] Self-Scheduled Assignments are sending expiration notifications #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sadsfae opened this issue Apr 24, 2025 · 2 comments
Closed

Comments

@sadsfae
Copy link
Member

sadsfae commented Apr 24, 2025

We shouldn't be sending expiration notifications for self-scheduled assignments because by design there is no way for tenants to extend them.

We might consider sending one a day before expiration as a notice but I'd be fine not sending any - they can look at and track their own reservations via the wiki.

@sadsfae
Copy link
Member Author

sadsfae commented May 4, 2025

self-scheduled assignments are sending the full 7,5,3,1 day expirations when they shouldn't send any (self-scheduled assignments cannot be extended and always expire based on ssm_deadline_day and ssm_deadline_hour per https://github.com/redhat-performance/quads/blob/latest/conf/selfservice.yml#L14

58056   C May 03 RDU2 Scale Lab  (   0) New QUADS Assignment Defined for the Future: cloud02 - 4275
58058   C May 03 RDU2 Scale Lab  (   0) Validation check succeeded for cloud02 / nchhabra / 4275
58059   C May 03 RDU2 Scale Lab  (   0) New QUADS Assignment Allocated - cloud02 4275
58060   C May 03 RDU2 Scale Lab  (   0) QUADS upcoming expiration for cloud02 - 4275
58061   C May 03 RDU2 Scale Lab  (   0) QUADS upcoming expiration for cloud02 - 4275

@grafuls
Copy link
Contributor

grafuls commented May 13, 2025

sadsfae pushed a commit that referenced this issue May 13, 2025
closes: #598
Change-Id: Ibd2b0c8746e913de68bfaf5e9715fa7e9f556946
@github-project-automation github-project-automation bot moved this from To do to Done in QUADS 2.2 Series May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants