-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHIDP-1918: updated the customzing theme section for a note #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this note lgtm. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@albarbaro: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Gerry-Forde, Could you please help with merge as well? we need to cherrypick this PR to 1.2.x branch. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
@shipsing Would you like me to merge this to |
yes, Gerry |
/cherrypick 1.2.x |
2 similar comments
/cherrypick 1.2.x |
/cherrypick 1.2.x |
@abrennan89: new pull request created: #266 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Purpose: To resolve this issue: https://issues.redhat.com/browse/RHIDP-1918
SME review: @jerolimov
QE review: @zdrapela
Peer review: @Gerry-Forde
Cherrypick version: 1.2.x
PR preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-233/getting-started-rhdh/#proc-customizing-the-web-console_rhdh-getting-started