Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHIDP-1918: updated the customzing theme section for a note #233

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

shipsing
Copy link
Member

@shipsing shipsing commented May 21, 2024

@rhdh-bot
Copy link
Collaborator

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this note lgtm. 👍

modules/proc-customizing-the-web-console.adoc Outdated Show resolved Hide resolved
@rhdh-bot
Copy link
Collaborator

@rhdh-bot
Copy link
Collaborator

@rhdh-bot
Copy link
Collaborator

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@albarbaro albarbaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented May 21, 2024

@albarbaro: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jun 7, 2024

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jun 7, 2024

@shipsing
Copy link
Member Author

shipsing commented Jun 7, 2024

@Gerry-Forde, Could you please help with merge as well? we need to cherrypick this PR to 1.2.x branch. Thanks

Copy link
Member

@Gerry-Forde Gerry-Forde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@Gerry-Forde
Copy link
Member

@Gerry-Forde, Could you please help with merge as well? we need to cherrypick this PR to 1.2.x branch. Thanks

@shipsing Would you like me to merge this to 1.2.x and main?

@shipsing
Copy link
Member Author

shipsing commented Jun 7, 2024

yes, Gerry

@Gerry-Forde Gerry-Forde merged commit 7cc77c5 into redhat-developer:main Jun 7, 2024
2 checks passed
@Gerry-Forde
Copy link
Member

/cherrypick 1.2.x

2 similar comments
@hmanwani-rh
Copy link
Member

/cherrypick 1.2.x

@abrennan89
Copy link
Member

/cherrypick 1.2.x

@openshift-cherrypick-robot
Copy link
Contributor

@abrennan89: new pull request created: #266

In response to this:

/cherrypick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants