-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHIDP-1908: Documenting the telemetry feature in admin guide #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced company name with the new attribute value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍️
Thanks!
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting this to blocked because we don't have DOCUMENTED approval from Legal to enable an opt-out telemetry feature.
If we change the code (and therefore the doc) to opt-in (disabled by default) then I'm otherwise happy with this PR.
New changes are detected. LGTM label has been removed. |
switching back to on-by-default despite vigorous protests that this is a BAD IDEA and that we don't have proper approvals.
We can go ahead and merge this. Just to confirm, we are going with enabled by default (opt-out) more information in https://issues.redhat.com/browse/RHIDP-1311 and the related parent feature |
Merging as we have approvals from at least a few people. |
Purpose: To resolve this issue: https://issues.redhat.com/browse/RHIDP-1908
SME review: @kadel @kim-tsao
QE review: @zdrapela
Peer review: @abrennan89
PR preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-212/admin-rhdh/#assembly-rhdh-telemetry_admin-rhdh
Related: https://issues.redhat.com/browse/RHIDP-58