feat: go to implementation/references/declaration/type definition with menu #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
go_to_implementation
branch
from
b4ca79a
to
12cea4b
Compare
fbricon
reviewed
May 15, 2024
fbricon
reviewed
May 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
+ Coverage 21.34% 21.83% +0.49%
==========================================
Files 245 259 +14
Lines 8372 8655 +283
Branches 1548 1570 +22
==========================================
+ Hits 1787 1890 +103
- Misses 6249 6408 +159
- Partials 336 357 +21 ☔ View full report in Codecov by Sentry. |
angelozerr
force-pushed
the
go_to_implementation
branch
10 times, most recently
from
0b62a41
to
16fb8a5
Compare
angelozerr
changed the title
angelozerr
force-pushed
the
go_to_implementation
branch
from
16fb8a5
to
630f051
Compare
angelozerr
force-pushed
the
go_to_implementation
branch
3 times, most recently
from
5fcd727
to
e9a8984
Compare
fbricon
reviewed
May 22, 2024
| @@ -42,14 +42,13 @@ Current state of [Language Features]( https://microsoft.github.io/language-serve | |||
| * ✅ [completionItem/resolve](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#completionItem_resolve) (see [implementation details](#completion-item-resolve)) | |||
| * ✅ [textDocument/signatureHelp](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_signatureHelp) (see [implementation details](#signature-help)) | |||
| * ✅ [textDocument/publishDiagnostics](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_publishDiagnostics) (see [implementation details](#publish-diagnostics)) | |||
| * ✅ [textDocument/definition](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_definition) | |||
There was a problem hiding this comment.
why did you remove it? definition != type definition
There was a problem hiding this comment.
Indeed but I removed it to avoid having duplication
angelozerr
force-pushed
the
go_to_implementation
branch
from
e9a8984
to
091499d
Compare
menu Signed-off-by: azerr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: go to implementation/references/declaration/type definition with menu