Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please clarify status of simplified_workflow_nodes #853

Open
dbk-rabel opened this issue Jul 1, 2024 · 2 comments
Open

Please clarify status of simplified_workflow_nodes #853

dbk-rabel opened this issue Jul 1, 2024 · 2 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@dbk-rabel
Copy link
Contributor

Hello.

From #297 it looks like simplified_workflow_nodes is old and should not be used anymore. From https://github.com/redhat-cop/controller_configuration/blob/devel/roles/workflow_job_templates/README.md that does not seem to be the case.

Could you clarify if one should use simplified_workflow_nodes?
And if not: What's the difference between workflow_nodes and simplified_workflow_nodes? Are they just interchangeable?

Yours
David

@dbk-rabel dbk-rabel added bug Something isn't working new New issue, this should be removed once reviewed labels Jul 1, 2024
@sean-m-sullivan
Copy link
Collaborator

we can update the wording and likely need to put in that they are depreciated. It is a holdover as removing it would be a breaking change, but we recommend using the workflow schema option. In other words we likely need to update the readme to make this clear that this is not recomended.

They are not interchangeable as the simplified was an OLD format predating even the ansible.controller collection, when the workflow_nodes option was added to the workflow job template module, I tried to make it interchangeable and it became a spaghetti code and abandoned. The current model is the one that is outputed from the awx-cli command line tool or export modules.

An in depth blog article about using the workflow_nodes is here: https://www.redhat.com/en/blog/automation-controller-workflow-deployment-as-code

@djdanielsson
Copy link
Collaborator

I think we should officially depreciate it in the next release and then remove it as a breaking change soon after

@djdanielsson djdanielsson added documentation Improvements or additions to documentation help wanted Extra attention is needed and removed new New issue, this should be removed once reviewed labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants