-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster load: Refresh prometheus_api connection in case of connection error #11327
base: master
Are you sure you want to change the base?
Conversation
… error Signed-off-by: Elad Ben Aharon <[email protected]>
ocs_ci/ocs/cluster_load.py
Outdated
)[0]["value"][1] | ||
) | ||
except requests.exceptions.RequestException as e: | ||
print(f"Encountered error: {e}. Refreshing connection and retrying...") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not critical, but better to replace print with log.error ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: Elad Ben Aharon <[email protected]>
Signed-off-by: Elad Ben Aharon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params: --io-in-bg --log-cluster-utilization
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master
Job FAILED (installation failed, tests not executed).
Triggered verification job here: |
Another verification here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params: --io-in-bg --log-cluster-utilization
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master
Job UNSTABLE (some or all tests failed).
Signed-off-by: Elad Ben Aharon <[email protected]>
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ebenahar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 similar comments
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ebenahar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ebenahar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Triggered new validation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation
Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params: --io-in-bg --log-cluster-utilization
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master
Job UNSTABLE (some or all tests failed).
Fixes #11328