Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster load: Refresh prometheus_api connection in case of connection error #11327

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ebenahar
Copy link
Contributor

@ebenahar ebenahar commented Feb 9, 2025

Fixes #11328

@ebenahar ebenahar requested a review from a team as a code owner February 9, 2025 14:00
@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Feb 9, 2025
)[0]["value"][1]
)
except requests.exceptions.RequestException as e:
print(f"Encountered error: {e}. Refreshing connection and retrying...")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not critical, but better to replace print with log.error ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Elad Ben Aharon <[email protected]>
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines and removed size/S PR that changes 10-29 lines labels Feb 10, 2025
Signed-off-by: Elad Ben Aharon <[email protected]>
@pull-request-size pull-request-size bot added size/S PR that changes 10-29 lines and removed size/M PR that changes 30-99 lines labels Feb 10, 2025
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params: --io-in-bg --log-cluster-utilization
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job FAILED (installation failed, tests not executed).

petr-balogh
petr-balogh previously approved these changes Feb 10, 2025
@petr-balogh
Copy link
Member

Triggered verification job here:
https://url.corp.redhat.com/2fedb4d

@petr-balogh
Copy link
Member

Another verification here:
https://url.corp.redhat.com/1974e44

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params: --io-in-bg --log-cluster-utilization
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

vavuthu
vavuthu previously approved these changes Feb 12, 2025
Signed-off-by: Elad Ben Aharon <[email protected]>
@ebenahar ebenahar dismissed stale reviews from vavuthu and petr-balogh via 0686d04 February 12, 2025 10:54
@openshift-ci openshift-ci bot removed the lgtm label Feb 12, 2025
Copy link

openshift-ci bot commented Feb 12, 2025

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ebenahar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

2 similar comments
Copy link

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ebenahar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ebenahar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-balogh
Copy link
Member

Triggered new validation:
https://url.corp.redhat.com/cc754c8
Where I cherrypicked commits from your PR here and my PR:
#11385

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/
Additional Test Params: --io-in-bg --log-cluster-utilization
OCP VERSION: 4.18
OCS VERSION: 4.18
tested against branch: master

Job UNSTABLE (some or all tests failed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S PR that changes 10-29 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClusterLoad: Sometimes the connection with Prometheus gets closed
5 participants