[Configuration] Add ability to specify file path without extension (#6839)

* [Configuration] Add ability to specify file path without extension

* fix

* fix

* final touch: ensure provide realpath()

* final touch: rename method for grammar

* final touch: ensure realpath() early

Author: samsonasik

src/Configuration/ConfigurationFactory.php

@@ -143,11 +143,33 @@ private function resolvePaths(InputInterface $input): array
 
         // give priority to command line
         if ($commandLinePaths !== []) {
+            $this->setFilesWithoutExtensionParameter($commandLinePaths);
             return $commandLinePaths;
         }
 
         // fallback to parameter
-        return SimpleParameterProvider::provideArrayParameter(Option::PATHS);
+        $configPaths = SimpleParameterProvider::provideArrayParameter(Option::PATHS);
+        $this->setFilesWithoutExtensionParameter($configPaths);
+
+        return $configPaths;
+    }
+
+    /**
+     * @param string[] $paths
+     */
+    private function setFilesWithoutExtensionParameter(array $paths): void
+    {
+        foreach ($paths as $path) {
+            if (is_file($path) && pathinfo($path, PATHINFO_EXTENSION) === '') {
+                $path = realpath($path);
+
+                if ($path === false) {
+                    continue;
+                }
+
+                SimpleParameterProvider::addParameter(Option::FILES_WITHOUT_EXTENSION, $path);
+            }
+        }
     }
 
     private function resolveMemoryLimit(InputInterface $input): string | null

src/Configuration/Option.php

@@ -307,4 +307,9 @@ final class Option
      * @internal The other half of ROOT_STANDALONE_REGISTERED_RULES to compare
      */
     public const SET_REGISTERED_RULES = 'set_registered_rules';
+
+    /**
+     * @internal to allow process file without extension if explicitly registered
+     */
+    public const FILES_WITHOUT_EXTENSION = 'files_without_extension';
 }

src/FileSystem/FilesFinder.php

@@ -70,6 +70,12 @@ public function findInDirectoriesAndFiles(
 
         $filteredFilePaths = array_filter($filteredFilePaths, $fileWithSuffixFilter);
 
+        // add file without extension after file extension filter
+        $filteredFilePaths = array_merge(
+            $filteredFilePaths,
+            SimpleParameterProvider::provideArrayParameter(Option::FILES_WITHOUT_EXTENSION)
+        );
+
         $filteredFilePaths = array_filter(
             $filteredFilePaths,
             function (string $file): bool {

tests-paths/path/NoExtensionFile

@@ -0,0 +1,3 @@
+<?php
+
+echo 'hi';

tests/Configuration/ConfigurationFactoryTest.php

@@ -15,15 +15,17 @@ public function test(): void
         $configurationFactory = $this->make(ConfigurationFactory::class);
         $configuration = $configurationFactory->createForTests([
             __DIR__ . '/../../tests-paths/path/*/some_directory/*',
+            __DIR__ . '/../../tests-paths/path/NoExtensionFile',
         ]);
 
         $filesFinder = $this->make(FilesFinder::class);
 
         $filePaths = $filesFinder->findInDirectoriesAndFiles($configuration->getPaths());
-        $this->assertCount(2, $filePaths);
+        $this->assertCount(3, $filePaths);
 
         $firstFilePath = $filePaths[0];
         $secondFilePath = $filePaths[1];
+        $thirdFilePath = $filePaths[2];
 
         $this->assertSame(
             realpath(__DIR__ . '/../../tests-paths/path/wildcard-nested/some_directory/AnotherFile.php'),
@@ -34,5 +36,10 @@ public function test(): void
             realpath(__DIR__ . '/../../tests-paths/path/wildcard-next/some_directory/YetAnotherFile.php'),
             realpath($secondFilePath),
         );
+
+        $this->assertSame(
+            realpath(__DIR__ . '/../../tests-paths/path/NoExtensionFile'),
+            realpath($thirdFilePath),
+        );
     }
 }