[dx] Prepend command name automatically if only paths are passed (#6759)

* [dx] prepare command name if nothing passed

* [readme] update to run without explicit command

* bump deps, use phpecs package

* [ci] add bare --help and --version run

Author: TomasVotruba

.github/workflows/code_analysis.yaml

@@ -29,6 +29,12 @@ jobs:
                         name: 'PHPStan'
                         run: vendor/bin/phpstan analyse --ansi
 
+                    -
+                        name: 'Help and Version'
+                        run:
+                            bin/rector --help
+                            bin/rector --version
+
                     -
                         name: 'Commented Code'
                         run: vendor/bin/swiss-knife check-commented-code src rules tests rules-tests --line-limit 5 --ansi

build/target-repository/README.md

@@ -60,13 +60,13 @@ return RectorConfig::configure()
 Then dry run Rector:
 
 ```bash
-vendor/bin/rector process src --dry-run
+vendor/bin/rector src --dry-run
 ```
 
 Rector will show you diff of files that it *would* change. To *make* the changes, drop `--dry-run`:
 
 ```bash
-vendor/bin/rector process src
+vendor/bin/rector src
 ```
 
 ## Documentation
@@ -124,7 +124,7 @@ See [the contribution guide](/CONTRIBUTING.md) or go to development repository [
 You can use `--debug` option, that will print nested exceptions output:
 
 ```bash
-vendor/bin/rector process src/Controller --dry-run --debug
+vendor/bin/rector src/Controller --dry-run --debug
 ```
 
 Or with Xdebug:
@@ -133,7 +133,7 @@ Or with Xdebug:
 2. Add `--xdebug` option when running Rector
 
 ```bash
-vendor/bin/rector process src/Controller --dry-run --xdebug
+vendor/bin/rector src/Controller --dry-run --xdebug
 ```
 
 To assist with simple debugging Rector provides 2 helpers to pretty-print AST-nodes:

composer.json

@@ -53,10 +53,10 @@
         "rector/swiss-knife": "^2.0",
         "rector/type-perfect": "^2.0",
         "shipmonk/composer-dependency-analyser": "^1.8",
-        "symplify/easy-coding-standard": "^12.5",
+        "phpecs/phpecs": "^2.1",
         "symplify/phpstan-extensions": "^12.0",
-        "symplify/phpstan-rules": "^14.0",
-        "symplify/vendor-patches": "^11.3",
+        "symplify/phpstan-rules": "^14.5",
+        "symplify/vendor-patches": "^11.4",
         "tomasvotruba/class-leak": "^2.0",
         "tracy/tracy": "^2.10"
     },

ecs.php

@@ -2,7 +2,6 @@
 
 declare(strict_types=1);
 
-use PhpCsFixer\Fixer\Casing\LowercaseKeywordsFixer;
 use PhpCsFixer\Fixer\Phpdoc\PhpdocTypesFixer;
 use Symplify\EasyCodingStandard\Config\ECSConfig;
 

src/Console/Command/ProcessCommand.php

@@ -105,7 +105,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $this->reportLevelOverflow($levelOverflow);
         }
 
-        // 0. warn about rules registered in both withRules() and sets to avoid bloated rector.php configs
+        // 1. warn about rules registered in both withRules() and sets to avoid bloated rector.php configs
         $setAndRulesDuplicatedRegistrations = $configuration->getBothSetAndRulesDuplicatedRegistrations();
         if ($setAndRulesDuplicatedRegistrations !== []) {
             $this->symfonyStyle->warning(sprintf(
@@ -115,7 +115,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             ));
         }
 
-        // 1. add files and directories to static locator
+        // 2. add files and directories to static locator
         $this->dynamicSourceLocatorDecorator->addPaths($paths);
         if ($this->dynamicSourceLocatorDecorator->isPathsEmpty()) {
             // read from rector.php, no paths definition needs withPaths() config

src/Console/ConsoleApplication.php

@@ -8,6 +8,7 @@
 use Rector\Application\VersionResolver;
 use Rector\ChangesReporting\Output\ConsoleOutputFormatter;
 use Rector\Configuration\Option;
+use Rector\Util\Reflection\PrivatesAccessor;
 use Symfony\Component\Console\Application;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputDefinition;
@@ -61,6 +62,18 @@ public function doRun(InputInterface $input, OutputInterface $output): int
             $output->write(PHP_EOL);
         }
 
+        $commandName = $input->getFirstArgument();
+
+        // if paths exist
+        if (is_string($commandName) && file_exists($commandName)) {
+            // prepend command name if implicit
+            $privatesAccessor = new PrivatesAccessor();
+            $tokens = $privatesAccessor->getPrivateProperty($input, 'tokens');
+            $tokens = array_merge(['process'], $tokens);
+
+            $privatesAccessor->setPrivateProperty($input, 'tokens', $tokens);
+        }
+
         return parent::doRun($input, $output);
     }
 

src/Parallel/Command/WorkerCommandLineFactory.php

@@ -41,8 +41,15 @@ public function create(
         int $port
     ): string {
         $commandArguments = array_slice($_SERVER['argv'], 1);
-        $args = [PHP_BINARY, $mainScript, ...$commandArguments];
 
+        // add implicit "process" command name if missing
+        if ($commandArguments !== [] && ($commandArguments[0] !== 'process' && $commandArguments[0] !== 'p') && ! defined(
+            'PHPUNIT_COMPOSER_INSTALL'
+        )) {
+            $commandArguments = array_merge(['process'], $commandArguments);
+        }
+
+        $args = [PHP_BINARY, $mainScript, ...$commandArguments];
         $workerCommandArray = [];
 
         $mainCommand = $this->commandFromReflectionFactory->create($mainCommandClass);