Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Subtitle Files for Offline Viewing #1371

Open
2 tasks done
tdadvocate opened this issue Oct 10, 2024 · 3 comments
Open
2 tasks done

Download Subtitle Files for Offline Viewing #1371

tdadvocate opened this issue Oct 10, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@tdadvocate
Copy link

Describe your suggested feature

When downloading the video, it should also download the subtitles file and create a new hard sub format. This way users can watch offline completely while traveling. Especially since most sites don't seem to do hard subs due to them generally sucking for multi-language use.

Other details

No response

Acknowledgements

  • My suggestion is NOT about adding a new provider
  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
@tdadvocate tdadvocate added the enhancement New feature or request label Oct 10, 2024
@tdadvocate
Copy link
Author

I just wanted to add, it seems like the original source had a bad subtitle link. I still think it would be nice to allow users to automatically create a hardcoded subtitled version of the video so that they could use other video player apps. Especially since the user cannot just search their downloaded videos within the app. If a source no longer has the video file, there is no way to watch the downloaded content.

@CranberrySoup
Copy link
Contributor

CranberrySoup commented Oct 10, 2024

Are you aware if this is possible without a big and complex dependency such as ffmpeg?
Your suggestion is good, but if it takes a disproportionate amount of time to implement, use and maintain then it will likely not be added.

@Turhvjbufv
Copy link

Turhvjbufv commented Oct 13, 2024

Describe your suggested feature

When downloading the video, it should also download the subtitles file and create a new hard sub format. This way users can watch offline completely while traveling. Especially since most sites don't seem to do hard subs due to them generally sucking for multi-language use.

Other details

No response

Acknowledgements

  • My suggestion is NOT about adding a new provider
  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.

Pretty sure it does it, it's just that you have to apply the subtitles automatically
At least that's my experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants