Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox in label is technically invalid #1138

Open
samgreen-spp opened this issue Nov 28, 2021 · 1 comment
Open

Checkbox in label is technically invalid #1138

samgreen-spp opened this issue Nov 28, 2021 · 1 comment

Comments

@samgreen-spp
Copy link

label elements should only contain phrasing content, which does not include div elements. The checkbox example is technically invalid for this reason since the Checkbox component is wrapped in a Box which defaults to a div. Would it be possible to provide a prop to change the type of tag that is used for this container element? For example, being able to set it to be a span

Screen Shot 2021-11-29 at 9 32 46 am

This guideline is defined in the following spec

Thanks for the awesome library :)

@shikhar13012001
Copy link

Hey @samgreen-spp , I would like to work on this issue can you please assign this to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants