Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PieArcSeries should not have a Doughnut property #23

Open
pfried opened this issue Nov 23, 2020 · 1 comment
Open

PieArcSeries should not have a Doughnut property #23

pfried opened this issue Nov 23, 2020 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@pfried
Copy link

pfried commented Nov 23, 2020

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[x] Other... Please describe:

Current behavior

The PieArcSeries has a Doughnut property which affects how the pie chart is rendered

Expected behavior

This does not really make sense, either you implicitly set the arcWidth or innerRadius or you will pass explicitly a DonutArcSeries which has the properties

What is the motivation / use case for changing the behavior?

imho it is just bad api design

Environment


Libs:
- react version: X.Y.Z
- reaviz version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@amcdnl
Copy link
Member

amcdnl commented Nov 23, 2020

I get it - its more of a shortcut for users who don't understand that. To be frank, I'm not sure I would have figured that w/o reading docs and I'm the author of the lib.

@amcdnl amcdnl added the documentation Improvements or additions to documentation label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants