Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document change in key typing #753

Open
jchavarri opened this issue Jul 19, 2023 · 1 comment
Open

Document change in key typing #753

jchavarri opened this issue Jul 19, 2023 · 1 comment

Comments

@jchavarri
Copy link
Collaborator

In some recent PR (I think #714) the types for key were strengthened. Before, one could essentially pass anything as key while now ReasonReact expects (correctly) for the key to be a string.

I think this should be documented somewhere as an improvement, and maybe be included in any future release posts as it is a "breaking" change (for the better).
@jchavarri
Copy link
Collaborator Author

See related #750 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jchavarri