Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundling with Metro warns with "Require cycles are allowed, but can result in uninitialized values." #6565

Open
kraenhansen opened this issue Mar 19, 2024 · 1 comment

Comments

@kraenhansen
Copy link
Member

We used to resolve these require cycles as part of producing a rollup bundle, but these will now surface as warnings when bundling with Metro.

We could probably revisit the decision to use a internal.ts to control the import order and instead focus on breaking the cycles:

* We're following [the internal module pattern](https://medium.com/visual-development/how-to-fix-nasty-circular-dependency-issues-once-and-for-all-in-javascript-typescript-a04c987cf0de) to control of the order of code when bundled.

@kraenhansen kraenhansen changed the title "Require cycles are allowed, but can result in uninitialized values." Bundling with Metro warns with "Require cycles are allowed, but can result in uninitialized values." Mar 19, 2024
Copy link

sync-by-unito bot commented Mar 19, 2024

➤ PM Bot commented:

Jira ticket: RJS-2769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant