RCORE-2080: Use the correct target conditional

[nielsenko]

What, How & Why?

Current master does not compile for iOS.

Fixed by changing a target conditional in keychain_helper.cpp. TARGET_OS_OSX means only mac, where as TARGET_OS_MAC includes iPhone, tvOS, etc. (see TargetConditionals.h). Apple works in mysterious ways.

Fixes: #7580

☑️ ToDos

📝 Changelog update
🚦 Tests (or not relevant)
C-API, if public C++ API changed
bindgen/spec.yml, if public C++ API changed

[coveralls-official]

Pull Request Test Coverage Report for Build github_pull_request_292823

Details

• 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
• 67 unchanged lines in 17 files lost coverage.
• Overall coverage increased (+0.03%) to 91.821%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/realm/object-store/impl/apple/keychain_helper.cpp	0	1	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/realm/array_key.cpp	1	98.61%
src/realm/sync/noinst/server/server.cpp	1	76.5%
test/test_dictionary.cpp	1	99.85%
test/test_index_string.cpp	1	94.63%
src/realm/cluster.cpp	2	77.52%
src/realm/object-store/shared_realm.cpp	2	93.01%
src/realm/query_expression.hpp	2	93.68%
src/realm/util/file.cpp	2	81.15%
src/realm/sync/network/network.cpp	3	89.52%
src/realm/sync/noinst/protocol_codec.hpp	3	76.08%

Totals
Change from base Build 2213:	0.03%
Covered Lines:	242956
Relevant Lines:	264596

---

💛 - Coveralls

[danieltabacaru]

The test failing is being fixed in #7542.

[jsflax]

Does this have any customer facing implications? Was something not working on iOS before? Do we need a CHANGELOG entry?