New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Give the Reagent examples some TLC #551
Labels
Comments
mchughs
changed the title
Give the Reagent example some TLC
[Proposal] Give the Reagent example some TLC
Nov 11, 2021
mchughs
changed the title
[Proposal] Give the Reagent example some TLC
[Proposal] Give the Reagent examples some TLC
Nov 11, 2021
Sounds good. Some of the examples are missing cljsjs react and react-dom dependencies as those were included in Reagent before 1.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was going through some of the examples, in particular the
react-context
and thefunctional-components-and-hooks
examples.I noticed a lot of little issues.
Problems with both:
lein-figwheel
, a deprecated build tool. With examples you want to just start them up as quickly as possible to play around with the underlying example. You don't want to fiddle with a build. I'd propose usingdeps.edn
andshadow-cljs
as I believe they are more standard nowadays, but if there is a particular affinity for lein and figwheel we could atleast move it tofigwheel-main
.Just in
react-context
:[cljsjs/react-sortable-hoc "1.11.0-0"]
as a depency ostensibly to just pull in react and react-dom?react/useContext
. This would require using the:>f
tag too.Just in
functional-components-and-hooks
:I'm happy to make an MR for these two and I can also take a look at the other ones as well. Is there anything I proposed which you disagree with?
The text was updated successfully, but these errors were encountered: