Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[India] Ethical Ads do not load, failing with Placement is configured with invalid parameters. #8799

Closed
pradyunsg opened this issue Jan 6, 2022 · 9 comments

Comments

@pradyunsg
Copy link

Tried on:

I noticed this while trying to get ads loading locally, as part of working on pradyunsg/sphinx-basic-ng#12.

Platform: Firefox 95.0.2 / Safari 15.2 / Chrome 96 on MacOS

@stsewd
Copy link
Member

stsewd commented Jan 6, 2022

They do work for me, tested on firefox and chromium, not sure what could be happening that doesn't load for you.

@pradyunsg
Copy link
Author

Here's a screenshot:

Screenshot 2022-01-06 at 20 56 51

Based on this comment:

https://github.com/readthedocs/ethical-ad-client/blob/005cde6b67c8b3d4126760c7e755aa5b65ad94dc/index.js#L424

It seems that this can also happen when there's no ad to show. I'm in India, which may have a role to play? Could you share a single ad ID for me to use (maybe the ReadTheDocs ad or something) to use with data-ea-force-ad?

@pradyunsg
Copy link
Author

It seems that this can also happen when there's no ad to show.

Yup, sounds about right. The JSONP response here was: ad_1641483214329_436596({});

@stsewd
Copy link
Member

stsewd commented Jan 6, 2022

I have connected to my VPN using an IP from India, I was able to replicate this.

@stsewd
Copy link
Member

stsewd commented Jan 6, 2022

/cc @davidfischer

@pradyunsg pradyunsg changed the title Ethical Ads do not load, failing with Placement is configured with invalid parameters. [India] Ethical Ads do not load, failing with Placement is configured with invalid parameters. Jan 6, 2022
@davidfischer
Copy link
Contributor

I'm almost certain this is just a bad error message when there's no ad to show. We should have a different one. I'll prioritize readthedocs/ethical-ad-client#26.

@pradyunsg
Copy link
Author

Is there any way for me to force an ad to be shown?

@technotip
Copy link

technotip commented Jan 11, 2022

I'm getting the same error message on my website. I was getting almost 30% fill rate till last month, but now I'm getting this error message "Placement is configured with invalid parameters" most of the time.

@pradyunsg
Copy link
Author

Closing this, since this is basically a duplicate of readthedocs/ethical-ad-client#26. Let's consolidate discussion over to that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants