Make entire version create url conditional

Author: agjohnson

readthedocs/projects/urls/private.py

@@ -1,5 +1,6 @@
 """Project URLs for authenticated users."""
 
+from django.conf import settings
 from django.conf.urls import url
 from django.contrib.auth.decorators import login_required
 from django.views.generic.base import RedirectView
@@ -82,11 +83,6 @@
         ProjectVersionDeleteHTML.as_view(),
         name='project_version_delete_html',
     ),
-    url(
-        r'^(?P<project_slug>[-\w]+)/version/create/$',
-        ProjectVersionCreate.as_view(),
-        name='project_version_create',
-    ),
     url(
         r'^(?P<project_slug>[-\w]+)/version/(?P<version_slug>[^/]+)/edit/$',
         ProjectVersionDetail.as_view(),
@@ -152,6 +148,18 @@
     ),
 ]
 
+# TODO move this up to the list above when it's not a conditional URL.
+# Currently, this is only used by the new theme, we don't allow for "create" in
+# our current templates.
+if settings.RTD_EXT_THEME_ENABLED:
+    urlpatterns.append(
+        url(
+            r'^(?P<project_slug>[-\w]+)/version/create/$',
+            ProjectVersionCreate.as_view(),
+            name='project_version_create',
+        ),
+    )
+
 domain_urls = [
     url(
         r'^(?P<project_slug>[-\w]+)/domains/$',

readthedocs/templates/projects/project_version_submit.html

@@ -2,8 +2,6 @@
 
 <p>
   <input style="display: inline;" type="submit" value="{% trans "Save" %}">
-  {% if version %}
-    {% trans "or" %}
-    <a href="{% url "wipe_version" version.project.slug version.slug %}">{% trans "wipe "%}</a>
-  {% endif %}
+  {% trans "or" %}
+  <a href="{% url "wipe_version" version.project.slug version.slug %}">{% trans "wipe "%}</a>
 </p>