feat: add merged jacoco report #271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbasle
reviewed
Feb 16, 2022
| @@ -186,6 +202,7 @@ configure(subprojects) { project -> | |||
| // dependencies that are common across all java projects | |||
| dependencies { | |||
| compile "io.projectreactor:reactor-core:$reactorCoreVersion" | |||
| compile 'org.jacoco:org.jacoco.agent:0.8.3' | |||
There was a problem hiding this comment.
we've never had to add the agent nor even the core jars in our projects before. can you clarify why this is needed?
simonbasle
requested changes
Feb 16, 2022
Comment on lines
+98
to
+101
| apply plugin: 'jacoco' | ||
| repositories { | ||
| mavenCentral() | ||
| } |
There was a problem hiding this comment.
why add this to this particular block? apply plugin: 'jacoco' above should be enough
| @@ -27,11 +27,13 @@ buildscript { | |||
| classpath 'org.springframework.build.gradle:propdeps-plugin:0.0.7' | |||
| classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:${kotlinVersion}" | |||
| classpath 'biz.aQute.bnd:biz.aQute.bnd.gradle:4.1.0' | |||
| classpath "org.jacoco:org.jacoco.core:0.8.3" | |||
There was a problem hiding this comment.
same as for agent, I don't believe we usually add core jacoco classpath
| } | ||
| } | ||
|
|
||
| plugins { | ||
| id "com.jfrog.artifactory" version "4.15.2" apply false | ||
| id 'jacoco' |
There was a problem hiding this comment.
should this be apply false if you're applying the plugin in each subproject ?
|
@olegshestakov I've just reworked and updated the build, including a bump to Gradle 7.4. this could remove the need for explicitly depending on jacoco 0.8.3 |
simonbasle
added
for/user-attention
simonbasle
added
status/declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #143