Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript version target for types #808

Open
taion opened this issue Apr 27, 2020 · 2 comments
Open

Fix TypeScript version target for types #808

taion opened this issue Apr 27, 2020 · 2 comments

Comments

@taion
Copy link
Member

taion commented Apr 27, 2020

See e.g. https://unpkg.com/browse/[email protected]/esm/Overlay.d.ts. This uses Omit, which doesn't work for older TS versions.

@kosmiq
Copy link

kosmiq commented Apr 27, 2020

What's the minimum version we should require and expect people to have? 3.5 that added omit was released in June 2019, is that too new?

@taion
Copy link
Member Author

taion commented Apr 27, 2020

Huh, is there anything else that might show up in our .d.ts files? The people reporting e.g. issues in CI but not locally esp. around <Modal> are making me suspicious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants